Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async iterator fix when Node 12 goes EOL #1223

Open
Tracked by #1452
jimmywarting opened this issue Jul 27, 2021 · 1 comment
Open
Tracked by #1452

Remove async iterator fix when Node 12 goes EOL #1223

jimmywarting opened this issue Jul 27, 2021 · 1 comment
Milestone

Comments

@jimmywarting
Copy link
Collaborator

jimmywarting commented Jul 27, 2021

Just so we don't forget... Should maybe remove the fix/hack about async iterator that got resolved in node v12+ or something like that once we drop support for node < 14

Maybe async iterator won't even be a issue when we decide to use whatwg streams? 🤔

Originally posted by @jimmywarting in #1222 (comment)

@jimmywarting jimmywarting added this to the Version 4.0.0 milestone Jul 27, 2021
@tekwiz
Copy link
Member

tekwiz commented Jul 27, 2021

Good call. The applicable blocks of code are:

  1. Starting with the c8 ignore directive: 8eeeec1#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R102
  2. Tests: 13cdcf3#diff-5a684c173d69bcc8d9e0e4b50ac83d8eaf640dbd8e141c14d9e1a953c87afbd3R638
  3. README documentation: 9cf8c18#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R305

@jimmywarting jimmywarting mentioned this issue Jan 14, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants