3.0.0 beta.10: TypeError: Cannot read property 'body' of null

[weijarz]

import fetch from 'node-fetch'

const response = await fetch('https://blog.logrocket.com/feed')
const body = await response.text()

console.log(body)

throws

file:///root/fetchbug/node_modules/node-fetch/src/index.js:99
			response.body.destroy(error);
			         ^

TypeError: Cannot read property 'body' of null
    at file:///root/fetchbug/node_modules/node-fetch/src/index.js:99:13
    at TLSSocket.<anonymous> (file:///root/fetchbug/node_modules/node-fetch/src/index.js:310:6)
    at TLSSocket.emit (events.js:327:22)
    at net.js:673:12
    at TCP.done (_tls_wrap.js:563:7)

software	version
node-fetch	3.0.0-beta.10
node	v14.16.0
npm	7.17.0
Operating System	archlinux

[jimmywarting]

Able to reproduce (must have something to do with redirects)
works in v2... works in 3.0.0-beta.9 also

[jimmywarting]

@octet-stream would you like to take a stab at #1220 #1219 before we ship v3?
I'm on vacation ATM. #1064 broke some stuff between beta.9 and beta.10

[octet-stream]

Will see what I can do.

[octet-stream]

It seems like the response is null when fixResponseChunkedTransferBadEnding calls its callback after the request has been redirected. There's no check for response being null here:

node-fetch/src/index.js

Lines 98 to 100 in b50fbc1

	fixResponseChunkedTransferBadEnding(request_, error => {
	response.body.destroy(error);
	});

Adding this check fixes this issue. But I'm not sure yet if this is the right solution. And I'm not one of node-fetch members so don't expect match from me because I'm unfamiliar with the codebase :D However I will figure this out.

[tekwiz]

@jimmywarting I'll take a look at this today.

[tekwiz]

@jimmywarting See #1222 for fix