New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node.js 12.20.0 and move to ESM #1141
Conversation
@xxczaki |
* Test on all minimum supported Node.js versions * Tweak Node.js workaround version range * Handle Node.js 16 aborted error message * fix node version string compare Co-authored-by: Jimmy Wärting <jimmy@warting.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work everyone! 🚀
No i haven't tested node-fetch but i have tried out formdata-polyfill and fetch-blob that is a ESM only pacakge. They are ESM only package and only have a the fetch-blob package have stuff like: Small side note: don't really like the look of this import mapping: so my reasoning is: don't mess with Alldoe it could be a good idea to do something like |
I won't die on my |
I don't have so strong feelings for it either. (even doe it might sound like it) |
node-fetch/node-fetch#1141 and node-fetch/node-fetch#810 should be proof these lads are high on acids
node-fetch/node-fetch#1141 and node-fetch/node-fetch#810 should be proof these lads are high on acids
What is the purpose of this pull request?
What changes did you make? (provide an overview)
Which issue (if any) does this pull request address?
#668
Is there anything you'd like reviewers to know?