Add support for Response.error() #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekwiz
requested changes
Jan 27, 2021
tkrotoff
force-pushed
the
response-error
branch
from
8d2df8b
to
f435028
Compare
tkrotoff
force-pushed
the
response-error
branch
from
f435028
to
83c2549
Compare
tinovyatkin
reviewed
Jan 28, 2021
tinovyatkin
reviewed
Jan 28, 2021
tekwiz
approved these changes
Jan 28, 2021
I don't see any reason why not, but I also think that would be outside the scope of the described intention for this pull request. |
|
Any news? :-) |
|
Ping |
|
@tinovyatkin Do you have any other changes that need to be made on this? |
tinovyatkin
approved these changes
Apr 20, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (provide an overview)
Add support for
Response.error()andtype: