schedule function emits with a parameter

[ImRodry]

I installed the package today and I noticed that whenever the schedule function executes the function we pass as an argument, it receives 1 parameter which is a date corresponding to the time at which it was ran. This is not documented and is quite annoying when passing functions to be called, expecting there to be no parameters passed. This isn't in the @types/node-cron package either so I assume it is a bug that I would be happy to PR a fix for, if you'd like.
As a note, this issue is caused by this line:

node-cron/src/task.js

Line 17 in fbc4039

exec = this._execution(now);

[merencia]

Hi @ImRodry, yep, I've added this to make the date that the task started available inside the task... I don't know if this makes sense anymore...

However, there are two PR (#221 and #190) that are adding the received options on scheduling as an extra param to the task function. I think passing the options is a good thing to allows pass some data to the task, and I wonder about adding a startedAt to the options before pass that to the task function.

What do you think?

[ImRodry]

From those two PRs I prefer the implementation in #190 that allows you to choose which args get passed when executing, and I think that PR could just remove now as a whole since it will always be Date.now (or new Date() if you want the full object). That also has some limitations which is that the passed args are static, which makes it rather redundant. IMO the best option would be to call the function with no parameters, since whatever you were gonna pass can always be obtained in some other way since it’s static. That would require a semver major change of course, so let me know what you think of that.

[ashishvarman]

I too got into problems because of this behavior. Request to kindly remove the now argument from the called function.