Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use defer with esbuild (fix: export defer from config) #740

Open
ztrange opened this issue Aug 21, 2023 · 1 comment
Open

Cannot use defer with esbuild (fix: export defer from config) #740

ztrange opened this issue Aug 21, 2023 · 1 comment

Comments

@ztrange
Copy link

ztrange commented Aug 21, 2023

Describe the bug
Since esbuild is only able to import stuff from the package's main field, if one tries to use defer in an application and bundle it with esbuild for node, it fails.

Submitting a PR for a failing test for the test suite is ideal.

Expected behavior
Ideally be able to import defer from the main package import, so that bundlers are able to find it.

Please tell us about your environment:

  • node-config version: 3.3.9
  • node-version: 18

Other information

@markstos
Copy link
Collaborator

This was implemented in the branch linked to from #569. That solution included shims so the old paths/names worked.

Someone interested in implementing this could check out that code. The maintainers won't be implementing this though: this PR will need to come from someone who would use the feature.

@markstos markstos changed the title Cannot use defer with esbuild Cannot use defer with esbuild (fix: export defer from config) Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants