Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to make regexes immutable #723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not try to make regexes immutable #723

wants to merge 2 commits into from

Conversation

CGNonofr
Copy link

@CGNonofr CGNonofr commented Mar 6, 2023

fixes #722

@markstos
Copy link
Collaborator

Please include a test suite test which fails before the change and passes afterwards.

@CGNonofr
Copy link
Author

Please include a test suite test which fails before the change and passes afterwards.

Just did in 9b9be2f

@markstos
Copy link
Collaborator

Thank you. I see the code also affects Date objects as well. Please make sure that case is covered by a test as well.

@markstos
Copy link
Collaborator

markstos commented May 1, 2023

Still waiting on the update for Dates.

@CGNonofr
Copy link
Author

CGNonofr commented May 2, 2023

There is no test file dedicated to Dates, I don't really know where to add it

@markstos
Copy link
Collaborator

Review the test suite and choose a good location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending-more-information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RegExp are proxified which breaks them
2 participants
@CGNonofr @markstos