Fixed issue with Buffers in config throwing error in util.makeImmutable

[Ginden]

Simple code replicating issue:

config/default.js

module.exports = {foo: Buffer.from('bar', 'ascii'), bar: 5};

index.js

require('config').get('bar')

[markstos]

This looks good, but since Buffer values are uncommon, let's put the check towards the end the chain of checks in makeImmutable, so we aren't checking every single value to see if it's a Buffer when most of them won't be.

[Ginden]

I don't think single instanceof check matters for performance of cold function.

On my PC checking one million elements take around 100ms.

var foo = false; 
var hrtime = process.hrtime();
for(let i = 0; i < 1000 * 1000; i++)  foo = foo || Buffer.isBuffer(String(i));

console.log(process.hrtime(hrtime))`

[markstos]

Ha, good enough. Merging.

[ekoeryanto]

need it soon

[lorenwest]

Can't believe this hasn't been published - apologies for it taking so long! Published in 3.3.2