fix: InterceptedRequestRouter.handleWrite arity issue
#2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
approved these changes
Jun 14, 2022
|
Thanks @gonza-lito! The remaining failing check is about formatting, it's not related to your changes. I'll take care of it |
gr2m
changed the title
InterceptedRequestRouter.handleWrite arity issue
|
🎉 This PR is included in version 13.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i found an issue with
InterceptedRequestRouter.handleWrite:Http.ClientRequest.write()can be invoked with a callback and no encoding, currently the code expected the callback to be the 3rd argument so if invoked the callback was never called.BTW: this is my first contribution ever, so If I'm doing something wrong let me know