Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Update mode #2241

Merged
merged 4 commits into from Nov 8, 2021
Merged

Added Update mode #2241

merged 4 commits into from Nov 8, 2021

Conversation

rkesters
Copy link
Contributor

@rkesters rkesters commented Nov 1, 2021

PR to implement #2237

@gr2m
Copy link
Member

gr2m commented Nov 1, 2021

could you add an update to the README please?

@rkesters
Copy link
Contributor Author

rkesters commented Nov 2, 2021

could you add an update to the README please?

updated

@rkesters
Copy link
Contributor Author

rkesters commented Nov 7, 2021

@gr2m can you approve running the checks.

@gr2m gr2m added the Recorder related to recording fixtures or Nock Back label Nov 7, 2021
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍🏼 Thanks Robert!

@gr2m gr2m merged commit 1cb4880 into nock:main Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

🎉 This PR is included in version 13.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link
Member

gr2m commented Nov 8, 2021

Ooops this should not have been merged automatically :/ The test coverage dropped

image

I'll take care of it

gr2m pushed a commit that referenced this pull request Nov 12, 2021
Included 'update' in the BackMode union, following the introduction of the update mode (#2241).
Copy link

@KRIANGSAK2532 KRIANGSAK2532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recorder related to recording fixtures or Nock Back released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants