Add query strings to .pendingMocks()

[josh18]

Context

Currently it is easy to miss that an interceptor isn't matching due to mismatching query strings.

Alternatives

This may be a breaking change if users are expecting specific messages so may not be ideal. An alternative would be to expose a new function such as pendingInterceptors() which would contain a lot more information that could be useful.

Has the feature been requested before?

I couldn't find any but there is another user who was confused by this: #2182

If the feature request is accepted, would you be willing to submit a PR?

Yes

[gr2m]

@mastermatt you wrote

nock.pendingMocks() is not meant to return the search component of the href

I wonder why though? Can you elaborate?

[mastermatt]

I don't know. A lot of nock comes from years of if-y documented incremental changes.
My comment is not a statement that it should behave like it does, just that it's current implementation does do it explicitly.

If I were to guess, I think its design was a judgement call how to represent pending interceptors as strings. One could argue that it should only rerun the host vs more and more eg. path, query, etc.

Personally I've never been a fan of it returning strings. Intuitively, I thought it should return Interceptors directly. 🤷
I only use it in afterEach test hooks. So I just have a little helper fn I use to get what I want.

[gr2m]

I only use it in afterEach test hooks

same :)

I'll dig more into nock's code next week, maybe I'll find out why the method behaves the way it currently does

[josh18]

So I just have a little helper fn I use to get what I want.

Are you keeping track of the interceptors separately? I don't think there is a way to access all the interceptors using nock is there?

pendingInterceptors() might be the better option to preserve legacy behaviour and enable more flexibility.