New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: node 16 compatibility #2199
Conversation
Thanks Vincent. Could you add a test that will fail with Node 16, and add node 16 to the CI test matrix? |
I added a test. I also tried to add node 16 on CI test matrix, but I'm not used to github workflows, so don't hesitate to point changes to do about it. |
I couldn't update your fork, so I created a new PR at #2201. I pushed the test commit and CI config update first to see it fail, and will then push your fix to see it pass |
still fails for me, see #2201. Feel free to continue to work on your PR, I can close mine, now that we've shown that tests fail on Node 16 |
I updated the failing test (seems related to node v16.2). |
🎉 This PR is included in version 13.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👍 |
Node v16 flags seems to have changed.
closes #2199