fix(recorder): escape single quotes in path of default output #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the default output of the recorder uses single quotes, any such quotes in the path would generate invalid Javascript.
paulmelnikow
approved these changes
Jan 30, 2021
| @@ -13,6 +13,8 @@ const servers = require('./servers') | |||
|
|
|||
| require('./setup') | |||
|
|
|||
| // TODO: the guts of this file should be wrapped in a `describe`. | |||
| // These before and afters run for every test in the repo under Mocha. | |||
|
Thanks Matt. |
|
馃帀 This PR is included in version 13.0.7 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
uxmaster
added a commit
to uxmaster/nock
that referenced
this pull request
Feb 1, 2021
fix(recorder): escape single quotes in path of default output (nock#2137)
This was referenced Mar 8, 2021
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the default output of the recorder uses single quotes, any such
quotes in the path would generate invalid Javascript.
I would prefer to use backticks, but went with escaping the single quote as the former would create a lot of unnecessary diffs for consumers commiting the output to version control (馃槈 @koerbcm).
Fixes: #2136