Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): move test assets to tests dir #1931

Merged
merged 1 commit into from Feb 25, 2020

Conversation

mastermatt
Copy link
Member

Also, rename fixture files to use consistent snake_case.

Also, rename fixture files to use consistent snake_case.
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure npm pack isn’t catching these files post move?

@mastermatt
Copy link
Member Author

0 ~/src/nock: npm pack --dry-run
npm notice
npm notice 📦  nock@0.0.0-development
npm notice === Tarball Contents ===
npm notice 1.1kB  LICENSE
npm notice 6.8kB  lib/back.js
npm notice 19.6kB lib/common.js
npm notice 1.2kB  lib/delayed_body.js
npm notice 94B    lib/global_emitter.js
npm notice 1.3kB  index.js
npm notice 13.6kB lib/intercept.js
npm notice 9.5kB  lib/intercepted_request_router.js
npm notice 17.9kB lib/interceptor.js
npm notice 2.1kB  lib/match_body.js
npm notice 10.6kB lib/playback_interceptor.js
npm notice 12.1kB lib/recorder.js
npm notice 10.7kB lib/scope.js
npm notice 1.8kB  lib/socket.js
npm notice 2.4kB  package.json
npm notice 353B   CHANGELOG.md
npm notice 51.4kB README.md
npm notice 7.7kB  types/index.d.ts
npm notice === Tarball Details ===
npm notice name:          nock
npm notice version:       0.0.0-development
npm notice filename:      nock-0.0.0-development.tgz
npm notice package size:  48.7 kB
npm notice unpacked size: 170.0 kB
npm notice shasum:        9f50eede3cec6f0568d54d2d943d4b254deb5eba
npm notice integrity:     sha512-piGFypiADC15A[...]0Wwwt5ngYm+Cw==
npm notice total files:   18

@mastermatt mastermatt merged commit 2c6c9dd into nock:master Feb 25, 2020
@mastermatt mastermatt deleted the move-test-assets branch February 25, 2020 01:46
@github-actions
Copy link

github-actions bot commented Mar 1, 2020

🎉 This PR is included in version 12.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants