New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test): Chai assert header matching #1925
Conversation
tests/test_header_matching.js
Outdated
const matchHeaderSpy = sinon.stub().returns(false) | ||
// TODO: It's surprising that this function receives a number instead of | ||
// a string. Probably this behavior should be changed. | ||
matchHeaderSpy.withArgs(456).returns(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it seems like this test should assert this call is the one that’s made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I missed that. updated.
message: 'Mocks not yet satisfied', | ||
}) | ||
|
||
expect(scope.isDone()).to.be.false() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tests/test_header_matching.js
Outdated
const matchHeaderSpy = sinon.stub().returns(false) | ||
// TODO: It's surprising that this function receives a number instead of | ||
// a string. Probably this behavior should be changed. | ||
matchHeaderSpy.withArgs(456).returns(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
🎉 This PR is included in version 12.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.