refactor(test): Mocha DSL for request overrider #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastermatt
commented
Feb 19, 2020
|
|
||
| // https://github.com/nock/nock/issues/1836 | ||
| test('when http.get and http.request have been overridden before nock overrides them, http.get calls through to the expected method', async t => { | ||
| // TODO Investigate why this is needed when it's also in the `afterEach()` |
There was a problem hiding this comment.
This todo and end hook is what prompted the investigation into retorting Sinon and led to the update in setup.js.
paulmelnikow
approved these changes
Feb 19, 2020
| @@ -18,6 +18,8 @@ afterEach(function() { | |||
| nock.restore() | |||
| nock.cleanAll() | |||
| nock.enableNetConnect() | |||
| nock.activate() | |||
| // It's important that Sinon is restored before Nock is reactivated for tests that stub/spy built-in methods, | |||
| // otherwise Sinon loses track of the stubs and can't restore them. | |||
There was a problem hiding this comment.
👍
Thanks for tracking down the issue!
|
🎉 This PR is included in version 12.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CR without whitespace still recommended.