Weekly Digest (9 February, 2020 - 16 February, 2020) #1904

weekly-digest · 2020-02-16T09:23:10Z

Here's the Weekly Digest for nock/nock:

ISSUES

Last week 25 issues were created.
Of these, 19 issues have been closed and 6 issues are still open.

OPEN ISSUES

💚 #1903 Setup sponsoring to Open Collective via GitHub sponsors, by gr2m
💚 #1902 Update dtslint to the latest version 🚀, by greenkeeper[bot]
💚 #1896 Release 12.x, by paulmelnikow
💚 #1885 Flaky time-related test in CI, by paulmelnikow
💚 #1883 New CI, by paulmelnikow
💚 #1882 ci: automatically commit and push formatted files, by merlinnot

CLOSED ISSUES

LIKED ISSUE

👍 #1879 fix(types): Scope accepts legacy Url not WHATWG, by mastermatt
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #1896 Release 12.x, by paulmelnikow
It received 33 comments.

PULL REQUESTS

Last week, 26 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 3 pull requests were updated.
💛 #1902 Update dtslint to the latest version 🚀, by greenkeeper[bot]
💛 #1882 ci: automatically commit and push formatted files, by merlinnot
💛 #1811 refactor: Use Mocha DSL for test_logging, by paulmelnikow

MERGED PULL REQUEST

COMMITS

Last week there were 19 commits.
🛠️ [test: Update got to the latest version and fill in missing coverage (#1825) * chore(package): update got to version 10.0.0

chore(package): update lockfile package-lock.json
Bump got again and run npm install
query -> searchParams
encoding -> responseType
{body: …} no longer implies .post()
auth -> username + password
query -> searchParams
Error now has a response property
Couple other fixes
Restore 100% coverage
Update lockfile
refactor(test): use Mocha DSL for allow unmocked (refactor(test): use Mocha DSL for allow unmocked #1894)
refactor(test): use Mocha DSL for allow unmocked
Fix format
baseUrl -> prefixUrl
Update json’s for breaking changes
update usage of prefixUrl.

There was a subtle, and I think unnecessary, change in Got 10.x where
using prefixUrl means the input, when making a request, can no longer
have a leading slash.
The prefix value can optionally have a trailing slash.
https://github.com/sindresorhus/got#prefixurl

Co-authored-by: Paul Melnikow github@paulmelnikow.com
Co-authored-by: Matt R. Wilson github@mattw.co](a275769) by greenkeeper[bot]
🛠️ [feat: allow passing a function to enableNetConnect() (#1889) * feat(1861): allow passing a function to enableNetConnect

Add test to cover passed parameters](566461b) by nikaspran
🛠️ Require Node 10+ (#1895) BREAKING CHANGE by paulmelnikow
🛠️ Update mkdirp to the latest version 🚀 (#1857) by greenkeeper[bot]
🛠️ Do not return the nock global from cleanAll() (#1872) BREAKING CHANGE by paulmelnikow
🛠️ [Drop support for String constructor (Drop support for String constructor #1873) BREAKING CHANGE

When checking types of strings, Nock will no longer recognize the String constructor, only string primitives.](6c504c3) by paulmelnikow
🛠️ refactor(test): use Mocha DSL for allow unmocked (#1894) * refactor(test): use Mocha DSL for allow unmocked by mastermatt
🛠️ ci: move semantic-release to GitHub Action by gr2m
🛠️ [test: fix assertRejects usage (#1890) As mentioned in https://github.com//pull/1889, it appears that assertRejects is not currently used correctly - the third parameter is the message that the assertion emits if it fails, not a matcher for the exception text.

This PR fixes all usages of assertRejects to correct expect on the error message.](524dd29) by nikaspran
🛠️ refactor(test): Chai assert allow unmocked (#1891) Convert assertions to Chai, prefer await over callback when appropriate, and replace Mikeal's Request with Got.
All in the name of prepping for Mocha DSL. by mastermatt
🛠️ Bump lolex and sinon (#1887) Lolex was renamed. by paulmelnikow
🛠️ [fix: allowMocked when using a callback for the path (#1877) * fix: allowMocked when using a callback for the path

When an Interceptor was created with a comparator for the path, the
matchOrigin function was comparing the string equivalent of the function
instead of evaluating it.

I'm not a fan of the fact that the function matchOrigin is comparing the
pathname, but that's a refactor for another day.

Fixes: #1867](9fdeeca) by mastermatt
🛠️ [fix: only activate once, when on (#1824) While debugging the Jest memory leak, I was surprised to find the Nock
was "activating" twice when imported. This is because intercept.js
was calling activate() directly AND back was setting the mode, which
calls restore() and activate(). There is no need for this double
initialization. Think of the CPUs we could be saving.
I also discovered that Nock "activates" even if the proc is started with
the NOCK_OFF env var set, which means Nock is polluting the global
scope even when callers have asked it not to.

Since it felt like the back.setMode() call was hiding in its module,
I've moved it to the entry index file and wrapped it in a isOn check.](a56a209) by mastermatt
🛠️ [Greenkeeper/semantic release 17.0.2 (#1878) * chore(package): update semantic-release to version 17.0.2

pin tap because 14.10.6 causes unexplained test errors.

Closes #1860](8b8a10d) by mastermatt
🛠️ fix(types): Scope accepts legacy Url not WHATWG (#1879) Updates the types to properly reflect that a Scope can be created with
the output of url.parse. Previously, it denoted that it accepted a
url.URL instance. To clarify, tests were also added proving that one
works while the other throws an error. by mastermatt
🛠️ [feat(socketDelay): support options.timeout (#1848) The current implementation only supports req.setTimeout, but Node.js
allows for options.timeout to accomplish the same.

https://nodejs.org/docs/latest-v12.x/api/http.html#http_http_request_url_options_callback](https://github.com/nock/nock/commit/061e922748c3d15fabec164042ff31e885da937c) by gurpreetatwal
🛠️ refactor: Use Mocha DSL in test_nock_lifecycle (#1809) by paulmelnikow
🛠️ Remove a spurious { retry: 0 } (#1876) This is set in got_client.js. by paulmelnikow
🛠️ ci: move format, lint and test jobs to GitHub Actions (#1814) by merlinnot

CONTRIBUTORS

Last week there were 7 contributors.
👤 greenkeeper[bot]
👤 nikaspran
👤 paulmelnikow
👤 mastermatt
👤 gr2m
👤 gurpreetatwal
👤 merlinnot

STARGAZERS

Last week there were 21 stagazers.
⭐ Sep0lkit
⭐ sterbur
⭐ OsirisXTLS
⭐ maucrvlh
⭐ kimihito
⭐ mahenrique94
⭐ brenopolanski
⭐ msafi
⭐ gabssnake
⭐ Tom-Bonnike
⭐ Xanonymous-GitHub
⭐ Sotyoyo
⭐ jonathangus
⭐ brunodb3
⭐ arijusg
⭐ wellici-js
⭐ nandastone
⭐ Mulder90
⭐ vreyespue
⭐ lourenci
⭐ johnbryant
You all are the stars! 🌟

RELEASES

Last week there were 6 releases.
🚀 v11.9.0 v11.9.0
🚀 v12.0.0-beta.1 v12.0.0-beta.1
🚀 v11.9.0-beta.1 v11.9.0-beta.1
🚀 v11.8.2 v11.8.2
🚀 v11.8.1 v11.8.1
🚀 v11.8.0 v11.8.0

That's all for last week, please 👀 Watch and ⭐ Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Feb 16, 2020

paulmelnikow closed this as completed Feb 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (9 February, 2020 - 16 February, 2020) #1904

Weekly Digest (9 February, 2020 - 16 February, 2020) #1904

weekly-digest bot commented Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #1904

Weekly Digest (9 February, 2020 - 16 February, 2020) #1904

Comments

weekly-digest bot commented Feb 16, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES