fix(types): Scope accepts legacy Url not WHATWG #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the types to properly reflect that a Scope can be created with the output of `url.parse`. Previously, it denoted that it accepted a `url.URL` instance. To clarify, tests were also added proving that one works while the other throws an error.
paulmelnikow
approved these changes
Feb 10, 2020
|
🎉 This PR is included in version 11.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the types to properly reflect that a Scope can be created with
the output of
url.parse. Previously, it denoted that it accepted aurl.URLinstance. To clarify, tests were also added proving that oneworks while the other throws an error.
This issue seems to be blocking the build of other PRs (#1878), probably because dtslint got a little smarter recently.
#1692 may be enough to add
url.URLsupport.