Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greenkeeper/semantic release 17.0.2 #1878

Merged
merged 7 commits into from Feb 10, 2020
Merged

Greenkeeper/semantic release 17.0.2 #1878

merged 7 commits into from Feb 10, 2020

Conversation

mastermatt
Copy link
Member

Closes: #1860

@mastermatt mastermatt requested a review from gr2m February 9, 2020 00:36
@mastermatt mastermatt mentioned this pull request Feb 9, 2020
Merged
paulmelnikow
paulmelnikow reviewed Feb 10, 2020
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has conflicts.

index.js Outdated Show resolved Hide resolved
@paulmelnikow paulmelnikow mentioned this pull request Feb 10, 2020
Closed
@mastermatt
Copy link
Member Author

I'm not sure why this is failing 'match domain using regexp with path as callback'.
It fails on my local too, but if I pull out the body of the test and run it straight in node, without Tap, it's fine.

@mastermatt
Copy link
Member Author

It passes if I convert it and run it as a Mocha test too. 😕

@paulmelnikow
Copy link
Member

So odd. I imagine it's something related to coverage instrumentation. Want to try pinning tap to 14.6.1 to avoid the bump to 14.10.6 that's happening when you npm install?

@mastermatt
Copy link
Member Author

yeah pinning Tap worked. lets get this out so it can unblock the build.

@mastermatt mastermatt merged commit 8b8a10d into master Feb 10, 2020
@mastermatt mastermatt deleted the greenkeeper/semantic-release-17.0.2 branch February 10, 2020 04:21
@nockbot
Copy link
Collaborator

nockbot commented Feb 10, 2020

🎉 This PR is included in version 11.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Feb 10, 2020
Closed
Closed
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

@gr2m gr2m Awaiting requested review from gr2m

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mastermatt @paulmelnikow @nockbot