Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Mocha DSL in test_nock_lifecycle #1809

Merged
merged 5 commits into from Feb 10, 2020
Merged

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Nov 7, 2019

  • Remove a duplicate test of isDone()


test('isDone', async t => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably easier to see in the side-by-side diff that these two tests of isDone() are doing the same thing.

@stale
Copy link

stale bot commented Feb 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@stale stale bot added the stale label Feb 5, 2020
@stale stale bot removed the stale label Feb 7, 2020
Copy link
Member

@mastermatt mastermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok with merging this in now or it waiting for something?

@paulmelnikow
Copy link
Member Author

Yea, I think it can be merged.

@paulmelnikow paulmelnikow merged commit c209c6b into master Feb 10, 2020
@paulmelnikow paulmelnikow deleted the mocha-lifecycle branch February 10, 2020 02:00
@nockbot
Copy link
Collaborator

nockbot commented Feb 10, 2020

🎉 This PR is included in version 11.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants