New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speeding up our builds #1792
Comments
It looks like we're linting an extra time in the Node 12 build which I'm opening a PR to fix. I guess the biggest wins without switching would be:
|
If you'd like me to, I can make a PR with a migration to GitHub Actions with full parallelization. |
Thanks for the offer! I haven't used GH Actions yet and I've been curious to give it a try. I'd be interested in @gr2m's thoughts on this. |
Yeah let's migrate to GH Actions. Thanks for the offer @merlinnot 👍 For reference, here is my current CI setup with GitHub Actions for tests & automated releases: https://github.com/octokit/core.js/tree/master/.github/workflows We can also do a separate workflow for linting with just Node 12. I definitely agree that slow CI builds is priority that needs to be addressed, I'm here to help in anyway I can, just keep pinging me :) |
Ok, great! I'll make a PR on Sunday or Monday evening. |
Better late than never 😄 #1814 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions. |
It's not stale, there's an open and active PR. |
🎉 This issue has been resolved in version 11.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I tend to work in streams of small PRs and when I've got a few of them to merge it becomes really apparent how long our builds take.
On some projects the build is done by the time I finish wrapping up the PR, and on nock that's never the case; it's always after I've moved on to something else. So sometimes it's not until the next day that I notice a build failure.
I clicked the update button on #1789 at 10:35 and the build completed at 10:46.
I'm more familiar with CircleCI where you can set concurrency, use your own images, and cache pieces of the install, though nock is so light that I think the builds would be under 2 minutes.
Are there things we can do to make Travis faster, or to get the build running more concurrently?
The text was updated successfully, but these errors were encountered: