Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (13 October, 2019 - 20 October, 2019) #1757

Closed
weekly-digest bot opened this issue Oct 20, 2019 · 0 comments
Closed

Weekly Digest (13 October, 2019 - 20 October, 2019) #1757

weekly-digest bot opened this issue Oct 20, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Oct 20, 2019

Here's the Weekly Digest for nock/nock:


ISSUES

Last week 14 issues were created.
Of these, 4 issues have been closed and 10 issues are still open.

OPEN ISSUES

💚 #1756 disableNetConnect is set with NOCK_BACK_MODE set to 'record', by meelash
💚 #1755 refactor: Rewrite a gnarly nested loop, by paulmelnikow
💚 #1754 refactor: Replace several more uses of lodash with native, and related refactors, by paulmelnikow
💚 #1753 docs: Revise and accept RFC-001, by paulmelnikow
💚 #1752 refactor: Correct the inverted logic of isUtf8Representable, by paulmelnikow
💚 #1749 docs: Mention strategy of testing common utility code, by paulmelnikow
💚 #1748 feat: Add lifecycle function to clear pending timeouts, by TLPcoder
💚 #1747 Do not disable mocks during recording, by dziamid
💚 #1746 The automated release is failing 🚨, by nockbot
💚 #1744 fix #1730 enforces the standard of passing a valid path as the uri param to the interceptor class, by TLPcoder

CLOSED ISSUES

❤️ #1751 refactor(test_allow_unmocked_https): Avoid a hardcoded port, by paulmelnikow
❤️ #1750 refactor(test_allow_unmocked_https): Replace Object.assign with spread, by paulmelnikow
❤️ #1745 chore: limit published files, by mastermatt
❤️ #1743 refactor(router): pass socket to IncomingMessage constructor., by mastermatt

LIKED ISSUE

👍 #1748 feat: Add lifecycle function to clear pending timeouts, by TLPcoder
It received 👍 x2, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #1744 fix #1730 enforces the standard of passing a valid path as the uri param to the interceptor class, by TLPcoder
It received 2 comments.


PULL REQUESTS

Last week, 11 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 3 pull requests were opened.
💚 #1754 refactor: Replace several more uses of lodash with native, and related refactors, by paulmelnikow
💚 #1753 docs: Revise and accept RFC-001, by paulmelnikow
💚 #1749 docs: Mention strategy of testing common utility code, by paulmelnikow

UPDATED PULL REQUEST

Last week, 4 pull requests were updated.
💛 #1755 refactor: Rewrite a gnarly nested loop, by paulmelnikow
💛 #1752 refactor: Correct the inverted logic of isUtf8Representable, by paulmelnikow
💛 #1748 feat: Add lifecycle function to clear pending timeouts, by TLPcoder
💛 #1741 allow for duplicate headers if the values are the same, by fizzy123

MERGED PULL REQUEST

Last week, 4 pull requests were merged.
💜 #1751 refactor(test_allow_unmocked_https): Avoid a hardcoded port, by paulmelnikow
💜 #1750 refactor(test_allow_unmocked_https): Replace Object.assign with spread, by paulmelnikow
💜 #1745 chore: limit published files, by mastermatt
💜 #1743 refactor(router): pass socket to IncomingMessage constructor., by mastermatt


COMMITS

Last week there were 4 commits.
🛠️ [refactor(test_allow_unmocked_https): Avoid a hardcoded port (#1751) This test was flaky on my machine.

I’ve also refactored to use async and the tap assertions a little more cleanly.](be011ea) by paulmelnikow
🛠️ refactor(test_allow_unmocked_https): Replace Object.assign with spread (#1750) by paulmelnikow
🛠️ chore: limit published files (#1745) By default, NPM will pack and publish all files in the directory.
For us, that was 50+ files including lint configs, Github templates,
RFCs, examples, etc.
This change limits the files to just those used by consumers when in the
context of a dependency. Plus what NPM always includes: README, LICENSE,
and CHANGELOG.
by mastermatt
🛠️ refactor(router): pass socket to response constructor. (#1743) Passing the socket from the request to the IncomingMessage is what
happens in native Node. Using a dummy EventEmitter then tacking the
socket onto the response later is kludge from historical tech-debt that
can now safely be cleaned up.
by mastermatt


CONTRIBUTORS

Last week there were 2 contributors.
👤 paulmelnikow
👤 mastermatt


STARGAZERS

Last week there were 59 stagazers.
fusionstrings
NoNameProvided
bodazhao
yhnavein
prashanthr
dtslvr
nealzhu
mohdule
drmflying
ericmm
lidianhao123
qoomon
alexsellam
miminas
mdartic
rafaelrpinto
hw0k
haijianyang
fobdy
josh-cain
krinoid
gunar
mrzzcn
okumurakengo
simongong
Yopadd
hliyan
petejank
billfeller
ktkization
will4906
brunosabot
peaceiris
necinc
jfplataroti
paulocsb
ancashoria
tangorri
emmanuelnk
danilovich
ipochinskiy
fedorovvldmr
thomasklemm
drubetti
mattwaler
maximzhurkin
joshmosh
arslivinski
yuzumi
xream
anisimov74
liupaiabc
PeterOnCode
NiaDavis
morais90
Abramovick
Bryan21B
kirit0s
gmcabrita
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant