Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Revise and accept RFC-001 #1753

Merged
merged 11 commits into from Feb 7, 2020
Merged

docs: Revise and accept RFC-001 #1753

merged 11 commits into from Feb 7, 2020

Conversation

paulmelnikow
Copy link
Member

I figure it's time to move forward with some of the proposals at improving this, and thought we ought to polish this a bit, and formally accept it.

I added a reference to #1118 and to the PRs where we'd discussed this material. The rest is copyedits for grammar and readability, and adding issue links.

@paulmelnikow
Copy link
Member Author

Hey @TLPcoder in the discussion at #1748 (comment) it sounded like you were interested in helping with the lifecycle methods. Would you be up for reviewing this?

TLPcoder pushed a commit to TLPcoder/nock that referenced this pull request Nov 3, 2019
@stale
Copy link

stale bot commented Jan 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@paulmelnikow
Copy link
Member Author

If no one objects, I will merge this.

@paulmelnikow paulmelnikow merged commit 921eacf into master Feb 7, 2020
@paulmelnikow paulmelnikow deleted the rfc-001-redux branch February 7, 2020 19:16
@nockbot
Copy link
Collaborator

nockbot commented Feb 10, 2020

🎉 This PR is included in version 11.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants