Weekly Digest (9 December, 2018 - 16 December, 2018)

[weekly-digest]

Here's the Weekly Digest for nock/nock:

---

ISSUES

Last week 14 issues were created.
Of these, 12 issues have been closed and 2 issues are still open.

OPEN ISSUES

💚 #1281 test(test_recorder): De-airplane more recorder tests, by paulmelnikow
💚 #1268 💌📯 Updates, by gr2m

CLOSED ISSUES

❤️ #1280 test(test_recorder.js): Remove AIRPLANE from a bunch of tests, by paulmelnikow
❤️ #1279 remove airplane mode for "records objects" test, by gr2m
❤️ #1278 test(test_recorder.js): Fix records test, by RichardLitt
❤️ #1277 remove AIRPLANE mode from test_nock_off, by gr2m
❤️ #1276 test(test_intercept.js): Remove pointless reqheaders test, by paulmelnikow
❤️ #1275 test(test_intercept.js): Test enableNetConnect without AIRPLANE, by paulmelnikow
❤️ #1274 tests: passthrough 1077, by RichardLitt
❤️ #1273 test: Install missing dev dependency for linting, by paulmelnikow
❤️ #1272 Fix #1271 for test_intercept.js, by paulmelnikow
❤️ #1271 Tests don't skip using --only when there is a hashmark in the test name, by RichardLitt
❤️ #1270 chore(setImmediate): use global.setImmediate instead of timers.setImmediate, by taylor1791
❤️ #1269 Hackathon coordination, by paulmelnikow

LIKED ISSUE

👍 #1269 Hackathon coordination, by paulmelnikow
It received 👍 x0, 😄 x0, 🎉 x1 and ❤️ x0.

NOISY ISSUE

🔈 #1269 Hackathon coordination, by paulmelnikow
It received 5 comments.

---

PULL REQUESTS

Last week, 19 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 9 pull requests were updated.
💛 #1281 test(test_recorder): De-airplane more recorder tests, by paulmelnikow
💛 #1235 [NockBack] Record "unmatched" requests only., by guerrerocarlos
💛 #1231 test: add failing test for JSON-encoded strings stored by recorder, by ctstone
💛 #1209 Nock-1077 Remove airplane mode, by jlilja
💛 #1109 Add test case for conflict between hostnames (#1108), by coleturner
💛 #1065 Failing tests for root URL parsing, by Overdrivr
💛 #587 enable object to be used in place of status code in reply api, by purezen
💛 #563 Use qs to parse body, for #507, by xavierchow
💛 #557 Adding test to prove that a header value can be an array (e.g. for Set-Cookie), by abstractvector

MERGED PULL REQUEST

Last week, 10 pull requests were merged.
💜 #1280 test(test_recorder.js): Remove AIRPLANE from a bunch of tests, by paulmelnikow
💜 #1279 remove airplane mode for "records objects" test, by gr2m
💜 #1278 test(test_recorder.js): Fix records test, by RichardLitt
💜 #1277 remove AIRPLANE mode from test_nock_off, by gr2m
💜 #1276 test(test_intercept.js): Remove pointless reqheaders test, by paulmelnikow
💜 #1275 test(test_intercept.js): Test enableNetConnect without AIRPLANE, by paulmelnikow
💜 #1274 tests: passthrough 1077, by RichardLitt
💜 #1273 test: Install missing dev dependency for linting, by paulmelnikow
💜 #1272 Fix #1271 for test_intercept.js, by paulmelnikow
💜 #1270 chore(setImmediate): use global.setImmediate instead of timers.setImmediate, by taylor1791

---

COMMITS

Last week there were 15 commits.
🛠️ test(test_recorder.js): Remove AIRPLANE from a bunch of tests Ref #1077 by paulmelnikow
🛠️ chore: remove obsolete comment [skip ci] by gr2m
🛠️ test: remove airplane mode for "records objects" test by gr2m
🛠️ test(test_recorder.js): Fix records test by RichardLitt
🛠️ Merge pull request #1277 from nock/1077/remove-airplane-mode-from-test_knock_off remove AIRPLANE mode from test_nock_off by RichardLitt
🛠️ test: remove airplaine mode from test/test_nock_off.js (#1077) by gr2m
🛠️ test(test_intercept.js): Remove pointless reqheaders test After studying this test for a good hour with @RichardLitt and @jlilja, we determined that it wasn’t asserting anything useful. There are other tests of reqheaders and we were unable to infer what this was intending to test. So, remove this one. Add clarifying comments in other tests we studied along the way. by paulmelnikow
🛠️ Merge pull request #1275 from nock/feat/netconnect-1077 test(test_intercept.js): Test enableNetConnect without AIRPLANE by RichardLitt
🛠️ Merge pull request #1274 from nock/feat/tests-pass-through tests: passthrough 1077 by RichardLitt
🛠️ test(test_intercept.js): Test enableNetConnect without AIRPLANE Ref #1077 by paulmelnikow
🛠️ tests: passthrough 1077 This adds server capabality to allow pass throughts for a couple of intercept tests. See #1077. by RichardLitt
🛠️ chore(setImmediate): use global.setImmediate instead of timers.setImmediate When unit testing, it is not uncommon to mock the clock. This includes controlling when setImmediate fires. By using global.setImmediate, we adhere to this expectation. This also avoids consumers having to mock the timers module. Resolves #677 by taylor1791
🛠️ Merge pull request #1273 from nock/fix-lint test: Install missing dev dependency for linting by RichardLitt
🛠️ chore: Install missing dev dependency for linting by paulmelnikow
🛠️ test: Fix #1271 for test_intercept.js Also ref: #1077 by paulmelnikow

---

CONTRIBUTORS

Last week there were 4 contributors.
👤 paulmelnikow
👤 gr2m
👤 RichardLitt
👤 taylor1791

---

STARGAZERS

Last week there were 44 stagazers.
⭐ tomodian
⭐ xiaoshu896448
⭐ dontcallmilanac
⭐ rijkerd
⭐ yclian
⭐ micheleangioni
⭐ mkorobkov
⭐ KlotzAtKoho
⭐ ilyaztsv
⭐ aleksey-chernov
⭐ yakiang
⭐ keemyb
⭐ rmtracey
⭐ turakvlad
⭐ doow118
⭐ boo-boom
⭐ tigressbailey
⭐ mindeng
⭐ jrobinsonc
⭐ tonestrike
⭐ imaginaryCorn
⭐ sys234
⭐ yonootz321
⭐ jcrashkit
⭐ haroldo-ok
⭐ jsmochin
⭐ MessagingMoore
⭐ agarcialeon
⭐ harunhasdal
⭐ gamefundas
⭐ fantomc0der
⭐ sharifhkhan
⭐ kmiasko
⭐ vnglst
⭐ bjornhanson
⭐ Tymek
⭐ FalconWiz
⭐ strix
⭐ pixelart7
⭐ pkeuter
⭐ paul-thebaud
⭐ jeremyben
⭐ SOHELAHMED7
⭐ istvano
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

[RichardLitt]

What a good week. :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!