forked from rubocop/rubocop
/
semicolon_spec.rb
202 lines (167 loc) · 4.91 KB
/
semicolon_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::Semicolon, :config do
let(:cop_config) { { 'AllowAsExpressionSeparator' => false } }
it 'registers an offense for a single expression' do
expect_offense(<<~RUBY)
puts "this is a test";
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
puts "this is a test"
RUBY
end
it 'registers an offense for several expressions' do
expect_offense(<<~RUBY)
puts "this is a test"; puts "So is this"
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
puts "this is a test"
puts "So is this"
RUBY
end
it 'registers an offense for one line method with two statements' do
expect_offense(<<~RUBY)
def foo(a) x(1); y(2); z(3); end
^ Do not use semicolons to terminate expressions.
^ Do not use semicolons to terminate expressions.
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
def foo(a) x(1)
y(2)
z(3)
end
RUBY
end
it 'accepts semicolon before end if so configured' do
expect_no_offenses('def foo(a) z(3); end')
end
it 'accepts semicolon after params if so configured' do
expect_no_offenses('def foo(a); z(3) end')
end
it 'accepts one line method definitions' do
expect_no_offenses(<<~RUBY)
def foo1; x(3) end
def initialize(*_); end
def foo2() x(3); end
def foo3; x(3); end
RUBY
end
it 'accepts one line empty class definitions' do
expect_no_offenses(<<~RUBY)
# Prefer a single-line format for class ...
class Foo < Exception; end
class Bar; end
RUBY
end
it 'accepts one line empty method definitions' do
expect_no_offenses(<<~RUBY)
# One exception to the rule are empty-body methods
def no_op; end
def foo; end
RUBY
end
it 'accepts one line empty module definitions' do
expect_no_offenses('module Foo; end')
end
it 'registers an offense for semicolon at the end no matter what' do
expect_offense(<<~RUBY)
module Foo; end;
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
module Foo; end
RUBY
end
it 'accept semicolons inside strings' do
expect_no_offenses(<<~RUBY)
string = ";
multi-line string"
RUBY
end
it 'registers an offense for a semicolon at the beginning of a line' do
expect_offense(<<~RUBY)
; puts 1
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(" puts 1\n")
end
it 'registers an offense for range (`1..42`) with semicolon' do
expect_offense(<<~RUBY)
1..42;
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
1..42
RUBY
end
it 'registers an offense for range (`1...42`) with semicolon' do
expect_offense(<<~RUBY)
1...42;
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
1...42
RUBY
end
context 'Ruby >= 2.6', :ruby26 do
it 'registers an offense for endless range with semicolon (irange only)' do
expect_offense(<<~RUBY)
42..;
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
(42..)
RUBY
end
it 'registers an offense for endless range with semicolon (irange and erange)' do
expect_offense(<<~RUBY)
42..;
^ Do not use semicolons to terminate expressions.
42...;
^ Do not use semicolons to terminate expressions.
RUBY
expect_correction(<<~RUBY)
(42..)
(42...)
RUBY
end
it 'registers an offense for endless range with semicolon in the method definition' do
expect_offense(<<~RUBY)
def foo
42..;
^ Do not use semicolons to terminate expressions.
end
RUBY
expect_correction(<<~RUBY)
def foo
(42..)
end
RUBY
end
it 'does not register an offense for endless range without semicolon' do
expect_no_offenses(<<~RUBY)
42..
RUBY
end
end
context 'with a multi-expression line without a semicolon' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
def foo
bar = baz if qux rescue quux
end
RUBY
end
end
context 'when AllowAsExpressionSeparator is true' do
let(:cop_config) { { 'AllowAsExpressionSeparator' => true } }
it 'accepts several expressions' do
expect_no_offenses('puts "this is a test"; puts "So is this"')
end
it 'accepts one line method with two statements' do
expect_no_offenses('def foo(a) x(1); y(2); z(3); end')
end
end
end