From 33610cacd221224132c4fc0025cfeec28927b266 Mon Sep 17 00:00:00 2001 From: Ahmet Yildirim Date: Thu, 7 Oct 2021 13:09:18 +0200 Subject: [PATCH 1/4] Implement get_refs function for DrtLambdaExpression --- nltk/sem/drt.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/nltk/sem/drt.py b/nltk/sem/drt.py index 4db47fdae5..1299b68c06 100644 --- a/nltk/sem/drt.py +++ b/nltk/sem/drt.py @@ -717,6 +717,12 @@ def _pretty(self): + [" " + blank + line for line in term_lines[3:]] ) + def get_refs(self, recursive=False): + """:see: AbstractExpression.get_refs()""" + return ( + [self.variable] + self.term.get_refs(True) if recursive else [self.variable] + ) + class DrtBinaryExpression(DrtExpression, BinaryExpression): def get_refs(self, recursive=False): From 583c020b3bec7b1213dc7eac90930a1a77a2782b Mon Sep 17 00:00:00 2001 From: Ahmet Yildirim Date: Thu, 7 Oct 2021 14:16:19 +0200 Subject: [PATCH 2/4] Update format --- nltk/sem/drt.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nltk/sem/drt.py b/nltk/sem/drt.py index 1299b68c06..50ee8a4ade 100644 --- a/nltk/sem/drt.py +++ b/nltk/sem/drt.py @@ -720,8 +720,8 @@ def _pretty(self): def get_refs(self, recursive=False): """:see: AbstractExpression.get_refs()""" return ( - [self.variable] + self.term.get_refs(True) if recursive else [self.variable] - ) + [self.variable] + self.term.get_refs(True) if recursive else [self.variable] + ) class DrtBinaryExpression(DrtExpression, BinaryExpression): From 3be6f495ee1b6c5324ac53772dc27945b52391ec Mon Sep 17 00:00:00 2001 From: Ahmet Yildirim Date: Tue, 12 Oct 2021 16:32:35 +0200 Subject: [PATCH 3/4] Fix TypeError: _pretty() takes 1 positional argument but 2 were given in sem/drt.py --- nltk/sem/drt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nltk/sem/drt.py b/nltk/sem/drt.py index fbd7e1e1f5..be236f02d3 100644 --- a/nltk/sem/drt.py +++ b/nltk/sem/drt.py @@ -898,7 +898,7 @@ def _pretty(self): ) if self.consequent: drs = DrtBinaryExpression._assemble_pretty( - drs, DrtTokens.IMP, self._pretty(self.consequent) + drs, DrtTokens.IMP, self.consequent._pretty() ) return drs From 87e23ff22fbdd14b5cd3ea44a48bcc46f50be551 Mon Sep 17 00:00:00 2001 From: Ahmet Yildirim Date: Tue, 12 Oct 2021 16:34:14 +0200 Subject: [PATCH 4/4] Add as author. --- AUTHORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.md b/AUTHORS.md index 2e45be55a8..cc1937035d 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -281,6 +281,7 @@ - Ruben Cartuyvels - Dalton Pearson - Saibo Geng +- Ahmet Yildirim ## Others whose work we've taken and included in NLTK, but who didn't directly contribute it: