Add Python 3.11 to CI & documentation #3090
Merged
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @tomaarsen. Hoping the issue with |
|
As for the failing tests - should we temporarily skip them, or should we just leave it be? |
|
I think it would be good if we temporally skipped the failing tests please, so new PRs don't show up as failing. |
|
Agreed. I'll skip the failing tests regardless of Python version, that seems easiest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3089
Hello!
Pull Request overview
Details
As of 2022-10-24, Python 3.11 has been fully released. As such, it is high time to officially add support for it in NLTK. This involves updating documentation and the CI test suite to ensure correct behaviour in Python 3.11. In this PR, I have done so. I believe to have updated all of the places where all valid Python versions are mentioned.