Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoreNLPServer non-default port issue (#2244) #3031

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Fix CoreNLPServer non-default port issue (#2244) #3031

merged 3 commits into from
Sep 1, 2022

Conversation

heungson
Copy link
Contributor

@heungson heungson commented Aug 8, 2022

Issue #2244 fixed.
In case where a port other than the default port (9000) is used, '-port' option is also added to the command line options.

tomaarsen
tomaarsen approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@tomaarsen tomaarsen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This works for me locally, too. Thank you for this!

@tomaarsen tomaarsen merged commit 0745094 into nltk:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaarsen tomaarsen tomaarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heungson @tomaarsen