Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge team page into develop #2941

Merged
merged 17 commits into from Jan 31, 2022
Merged

Merge team page into develop #2941

merged 17 commits into from Jan 31, 2022

Conversation

stevenbird
Copy link
Member

cf #2855

tomaarsen and others added 16 commits October 14, 2021 21:31
@tomaarsen
Reworked team page structure
d48600c
@tomaarsen
Removed previous_team.html, which has been superseded by former_team.…
dd895eb 
…html
@tomaarsen
Fixed Mustache tag for GitHub user link
535a880
@tomaarsen
Former NLTK members -> Former NLTK Team Members
ca22abe
@tomaarsen
Prevent Former NLTK Team Members to appear seperately on the Table of…
8bee5f9 
… Contents
@tomaarsen
Allow creating a quick link to a certain team member
2ddc1e9
@tomaarsen
Increase padding between members
907b678
@tomaarsen
Use rem instead, seems to align better
24a2545
@tomaarsen
Merge branch 'develop' into feature/team-page
74782f5
@tomaarsen
Moved to using Jinja2 + small formatting changes
e217f5f
@tomaarsen
Added 'This file is autogenerated by ...' to all autogeneration file …
b17b889 
…templates
@tomaarsen
Take GitHub profile picture as the photo for the team page
5c49e41
@tomaarsen
Merge branch 'develop' of https://github.com/nltk/nltk into team
bc00f99
@tomaarsen
Open template files with utf8
f4167aa
@tomaarsen
Created initial team.json, subject to change!
ee79359 
Note that I may have forgotten members, taken the wrong active range, or applied an inapplicable Role
@stevenbird
merge edits from feature/team-page branch
118a542
@tomaarsen
Refreshed former_team.html and current_team.html
2550089 
By running sphinx-build -E web build. This calls generate_custom_files from web/conf.py, which (re)generates these files.
tomaarsen
tomaarsen approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stevenbird stevenbird merged commit 9494bcc into develop Jan 31, 2022
@stevenbird stevenbird deleted the team branch January 31, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaarsen tomaarsen tomaarsen approved these changes

Assignees

@tomaarsen tomaarsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenbird @tomaarsen