Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small enhancements and improvements #2939

Merged
merged 22 commits into from
Mar 31, 2022
Merged

Small enhancements and improvements #2939

merged 22 commits into from
Mar 31, 2022

Conversation

tomaarsen
Copy link
Member

Hello!

Pull request overview

I'll structure this PR a little bit differently. Rather than explaining the changes here, I'll add comments to each of the changed files to indicate my reasoning for making the changes.

I also invite @leifwalsh to verify my attempted fix for #2938.

  • Tom Aarsen

@tomaarsen
Remove unused import
3cb001b
@tomaarsen
Use regex instead of re to combat exponential backtracking
2b8a4c1 
caused by a Large Starting Qualifier. This is not a ReDoS as this has no attack vector - the compilation is only slow if the compilation fails, and if a compilation is allowed to fail, then there are likely other issues to take care of.
@tomaarsen
Return langs as a list, rather than a dict_keys object
97cb163
@tomaarsen
no -> No as the start of a sentence
038b615
@tomaarsen
Title-cased first words of more Exceptions
123f0d9
@tomaarsen
Modernised string formatting in Exceptions
a78fbe1
@tomaarsen
Added a __all__ in tree/__init__.py for safety
c1b311f
@tomaarsen
Removed unused assignments
d84040b
@tomaarsen
Simplified unneeded list comprehension
024b490
@tomaarsen
Removed old unreachable statement by Ed Loper
581d7c8
@tomaarsen
Fixed DependencyGrammar __contains__ which takes an argument too many
247bdc0
@tomaarsen
Remove unused import
0cd39ec
@tomaarsen
Resolve ModuleNotFound in _lemmatize in RTE Feature Extractor
742a109
@tomaarsen
Renamed unused loop variable to _
18bf2bd
@tomaarsen
Deleted unused imports
9138103
@tomaarsen
Revert to using a list comprehension
21e20d0 
This reverts commit 024b490.
@tomaarsen
Made importing more precise
c0fa6ec
@tomaarsen
Rely on (deep)copy to optimize mathematical operators of ConditionalF…
62fd4d1 
…reqDist
@tomaarsen
Merge branch 'develop' of https://github.com/nltk/nltk into enhanceme…
2c0985a 
…nt/lgtm-fixes
@tomaarsen
Removed left-over debugging
3f6db28
tomaarsen
tomaarsen commented Jan 26, 2022
View reviewed changes
nltk/chunk/regexp.py Show resolved Hide resolved
nltk/classify/rte_classify.py Show resolved Hide resolved
nltk/classify/rte_classify.py Show resolved Hide resolved
nltk/corpus/reader/wordnet.py Show resolved Hide resolved
nltk/corpus/reader/wordnet.py Show resolved Hide resolved
nltk/probability.py Show resolved Hide resolved
nltk/tree/__init__.py Show resolved Hide resolved
nltk/tree/prettyprinter.py Show resolved Hide resolved
nltk/tree/tree.py Show resolved Hide resolved
nltk/util.py Show resolved Hide resolved
@tomaarsen tomaarsen linked an issue Feb 1, 2022 that may be closed by this pull request
ConditionalFreqDist.__add__ is quadratic time-ish #2938
Closed
@stevenbird stevenbird self-assigned this Mar 26, 2022
@stevenbird stevenbird merged commit 98a3a12 into nltk:develop Mar 31, 2022
@stevenbird
Copy link
Member

Nice work :)

@tomaarsen tomaarsen deleted the enhancement/lgtm-fixes branch March 31, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leifwalsh leifwalsh leifwalsh left review comments

@stevenbird stevenbird stevenbird left review comments

Assignees

@stevenbird stevenbird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConditionalFreqDist.__add__ is quadratic time-ish
3 participants
@tomaarsen @stevenbird @leifwalsh