New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.6, support Python 3.10 #2920
Conversation
This PR is now planned to be merged after the upcoming NLTK release (3.6.6), allowing existing Python 3.6 users to benefit from our changes over the past months. |
Merged, now that 3.6.6 is released. |
Thanks @tomaarsen, @purificant |
Weirdly enough - these tests passed, but every single CI run after this PR fails to build scikit-learn on Windows. I've removed CI tests for Windows 10 for now, until scikit-learn 1.0.2 releases (planned in middle December 2021), which supposedly adds support for Python 3.10 in Windows. |
…develop * 'develop' of https://github.com/ExplorerFreda/nltk: Temporarily pause Python 3.10 CI tests due to scikit-learn issues with Windows Resolve IndexError in `sent_tokenize` (nltk#2922) Drop support for Python 3.6, support Python 3.10 (nltk#2920) updates for 3.6.6 minor clean ups updates for 3.6.6
This reverts commit 0b8c2d5. This was reverted initially to allow Python 3.6 users to use NLTK 3.6.7, which contains a bug-fix for NLTK 3.6.6.
Closes #2912, closes #2913
Hello!
Pull request overview
python_requires
insetup.py
to>=3.7
instead of>=3.6
.Note
I left mentions of Python 3.6 in the tools folder, e.g. in
run_doctests.py
:nltk/tools/run_doctests.py
Lines 10 to 16 in 6411fab
This folder seems mostly outdated and unused, also containing references back to jenkins and travis. One of the files,
run_doctests.py
, is not the proper way that doctests should be ran regardless. I didn't worry about these cases too much.Thanks to @purificant for the commit of his I borrowed from his Python 3.10 branch :)
We should prepare a release soon.