Deprecate 'return_str' parameter in NLTKWordTokenizer and TreebankWordTokenizer #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaarsen
requested changes
Nov 10, 2021
There was a problem hiding this comment.
I have two small comments on your work. Beyond that, looks great!
Eventually we'll want the deprecation of return_str to be described in the method documentation, but the PR for that documentation is still open: #2878. That's something for when both this and that PR are merged (or at least one of the two).
adamjhawley
force-pushed
the
feature/deprecate_return_str
branch
from
6b78e28
to
7f6ebf8
Compare
|
@tomaarsen thanks for the review! I have amended the commit to contain your suggestions |
tomaarsen
approved these changes
Nov 11, 2021
stevenbird
approved these changes
Nov 12, 2021
|
I have a nit comment, I would suggest refactoring the if's in Treebank and WordTokenizer to be: instead of It is more readable and faster. Also, it is more pythonic and follows the PEP8 standard. |
tomaarsen
reviewed
Nov 15, 2021
as suggested by 12mohaned
|
Thanks @adamjhawley, @12mohaned, @tomaarsen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2879
As per the discussion on #2879, I have deprecated the use of the 'return_str' parameter in the
tokenizemethod of bothNLTKWordTokenizerandTreebankWordTokenizer.I have currently done this in a way that raises a
DeprecationWarningif a non-default value is passed to the parameter.