Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull request overview
The cleanup
I've already deleted
.travis.yml
,jenkins-job-config.xml
andjenkins.sh
from the root in this PR, as we no longer use these files. If we ever decide to return to these services (which I doubt greatly), then we can always just look in the git history to find them again.There are also jenkins and travis specific files elsewhere, specifically under
tools/travis
andtools/jenkins
, but these files aren't really "in the way" as much. That said, I'm open to also deleting these.Other files
There are some other files in the root directory which might be somewhat unnecessary:
pip-req.txt
andrequirements-ci.txt
/requirements-test.txt
don't have the same naming structure. Perhaps we can change this? (To be honest, I don't remember ever seeing apip-req.txt
file before NLTK - I only encounterrequirements.txt
)