Corrected __init__ call for SyntaxCorpusReader subclasses #2872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2118
Hello!
Pull request overview
CorpusReader.__init__(...)
withSyntaxCorpusReader.__init__(...)
on classes that inherit fromSyntaxCorpusReader
.Details
See #2118 for details on the issue.
Beyond that:
SyntaxCorpusReader
inherits fromCorpusReader
, and the former doesn't specify a__init__
, so both methods are identical. That means, we can just go for the logical option of calling__init__
on the parent we are actually inheriting from.