Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest version of pip in CI pipeline #2846

Merged
merged 1 commit into from Oct 9, 2021

Conversation

purificant
Copy link
Member

Small tweak to CI.

1 Use latest version of pip to install dependencies. There can be some variation depending on which python version is used, this ensures the latest version.
2 Use --no-cache-dir during dependency installation, this avoid creating local pip cache which is redundant because it is discarded between runs and because we are caching the entire python environment with all installed dependencies.

This PR should not conflict with #2820, however, it's probably a good idea to merge #2820 first.

@tomaarsen
Copy link
Member

Out of curiosity, do we know that pip isn't already initialized to the highest version by default when Python is set up?

@purificant
Copy link
Member Author

Out of curiosity, do we know that pip isn't already initialized to the highest version by default when Python is set up?

Yes, I know this to be true from experience. Recently GitHub actions started to show a warning when this happens for py3.10. It's also a common pattern that I use when building containers and CI pipelines but it hasn't been implemented here initially. It's worth adding imo.

Copy link
Member

@tomaarsen tomaarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, let's do this then!

@purificant
Copy link
Member Author

Rebased the branch to use latest code from develop now that #2820 was merged.

@stevenbird stevenbird merged commit c05b0e7 into nltk:develop Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants