Updating third party tools to newer versions and removing MaltParser fixed version #2832
Conversation
There was a problem hiding this comment.
Regarding the changes to the travis file - I'm afraid we won't need those. And for the MaltParser, we're looking for a more involved fix that tackles the weird dynamic I've described in my other comment.
It's up to you whether you want to try and tackle those issues, or if you want to leave it. If you choose the former, then maybe it would be best to wait until #2820 is either closed or merged.
|
Thanks, @tomaarsen, I see that is now merged and I am trying to update this PR. And if there is anything I can contribute please let me know Thanks |
|
Of course! Perhaps the links in https://github.com/nltk/nltk/blob/develop/tools/github_actions/third-party.sh that gather the third party applications can be updated. Beyond that, any problem from https://github.com/nltk/nltk/issues can be tackled. |
|
Apologies, I did not mean to close this. |
|
I'm trying to do some testing, but it seems that GitHub is having some issues with their |
There was a problem hiding this comment.
I've removed the parser_dirname parameter from a few test cases, where the path to the actual executable should be supplied via the MALT_PARSER environment variable. This would completely fix the issue #2826! I believe with your changes, this should pass just fine.
If it does, then I'll merge this, and reset the CI cache so that it indeed downloads the new versions of MaltParser and the CoreNLP tools for all future test runs.
|
These changes look great. Thank you @gavishpoddar! |
|
Thanks, @tomaarsen for helping me throughout the PR and the merge |
Hello,
This micro pull request updates third party tools to newer versions (Stanford
corenlp,postagger,parser) (#2826) and removes MaltParser fixed version. (#2827)I am trying the fix the above-listed issues please let me know if changes are required.
Thanks