Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot function bugs fixed #2319

Merged
merged 5 commits into from Jul 4, 2019
Merged

Conversation

BLaZeKiLL
Copy link
Contributor

@BLaZeKiLL BLaZeKiLL commented Jun 13, 2019

  • fixed matplot lib import
  • fixed samples query (v definition)
  • fixed frequency and labels logic
  • fixed test_plot unit test input arguments
  • fixed non existent conditions

- fixed matplot lib import
- fixed samples query (v definition_
- fixed frequency and labels logic
if added to samples query to check if c in self
conditions input for the test plot should be a list for strings rather than a string
previously samples used to check if c in self and that would pass the unit test 
The output would be a graph with no plots but a legend with non existent conditions
The correct output should have no conditions in the legend for non existent keys
Hence in the case of conditions being supplied through kwargs it need to be checked with self(conditions exist in self or not)
@stevenbird stevenbird merged commit 8bcc98a into nltk:develop Jul 4, 2019
@stevenbird
Copy link
Member

Thanks @BLaZeKiLL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants