Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: created a new next.js page called login #603 #698

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kingdanie
Copy link
Contributor

Describe your changes

created a new next.js page called login and also added a simple test to the client.cy.js file.

Issue ticket number and link

closes #603

@ijemmao
Copy link
Collaborator

ijemmao commented Jun 24, 2023

@kingdanie thanks for this change! can you please attach as many relevant screenshots of this visual change?

Copy link
Collaborator

@ijemmao ijemmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start! and i'm loving the new Cypress test!

i just left comments mainly about how we want to use ChakraUI and how we want to order our constants, useEffect, and return statement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to start using ChakraUI for all our components (i.e. Box, Heading, Form, Button, Text to replace div, h1, h2, form, button, p, etc.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will try to refactor the page to reflect these changes.

Copy link
Contributor Author

@kingdanie kingdanie Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrakra ui components doesn't seem to work well with tailwind classes especially for Box, and Formcontrol.
See screenshots for before I changed div and form to Box and Formcontrol respectively:

Screenshot 2023-06-27 at 10 27 35 Screenshot 2023-06-27 at 10 27 45

Additionally from the screenshots, you can see that the headers are also not the same. Here is a code snippet:

 <div className="w-10/12 lg:w-7/12">
            <Heading as="h1" fontSize="4xl" className="mb-6">{t('Log in.')}</Heading>
            <h1 className="text-5xl mb-6">{t('Log in.')}</h1>

            <Heading as="h2"  fontSize='md' className="text-gray-600 mb-4">{t('Log in to your Igbo API dashboard.')}</Heading>
            <h2 className="text-gray-600 font-normal mb-4">{t('Log in to your Igbo API dashboard.')}</h2>
 </div>

src/pages/login.js Outdated Show resolved Hide resolved
src/pages/login.js Outdated Show resolved Hide resolved
src/pages/login.js Outdated Show resolved Hide resolved
src/pages/login.js Outdated Show resolved Hide resolved
@kingdanie
Copy link
Contributor Author

Current view of the login page
Screenshot 2023-06-27 at 12 03 33

@ijemmao
Copy link
Collaborator

ijemmao commented Jul 1, 2023

@kingdanie are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new Next.js page called login
2 participants