Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add execvpe support, conditional on platform #975

Merged
merged 1 commit into from Nov 23, 2018
Merged

Add execvpe support, conditional on platform #975

merged 1 commit into from Nov 23, 2018

Conversation

F1rst-Unicorn
Copy link
Contributor

This closes #682

@F1rst-Unicorn F1rst-Unicorn mentioned this pull request Nov 18, 2018
Open
asomers
asomers requested changes Nov 18, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks pretty good. I just have a few minor requests about the documentation.

src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
src/unistd.rs Outdated Show resolved Hide resolved
@F1rst-Unicorn
Copy link
Contributor Author

I adapted your change requests (not sure whether I shall also "Resolve conversation"...)

asomers
asomers approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 23, 2018
@bors @F1rst-Unicorn
Merge #975
6920394 
975: Add execvpe support, conditional on platform r=asomers a=F1rst-Unicorn

This closes #682 

Co-authored-by: F1rst-Unicorn <f1rst_unicorn@njsm.de>
@bors
Copy link
Contributor

bors bot commented Nov 23, 2018

Build succeeded

@bors bors bot merged commit 35c0d63 into nix-rust:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add execvpe support
2 participants
@F1rst-Unicorn @asomers