Get SO_PEERCRED working on all Linux targets
#921
Conversation
|
CI passes, so I've squashed and added a changelog entry. |
|
@berkowski @Susurrus can you comment about why these socket options were disabled? Is there any problem with reenabling them? |
|
They were disabled at the time to get nix passing arm-based tests. There's been a lot of changes in the upstream libs since then so maybe a few missing symbols were added? I don't have the knowledge to say definitively whether that flag is valid on all platforms. I'd trust it is if libc exports it at this point. |
|
@berkowski do you recall if the arm-based tests were failing deterministically, or intermittently? |
|
@asomers, I don't remember specifics, sorry. Most of my effort at that time was just getting nix (and libc) to compile under the new architectures exposed by trust. I'd guess that I was chasing down compile-time issues rather than run-time test failings. |
|
That sounds likely, and it's certainly working now. However, It's developed a merge conflict in the changelog. @jonas-schievink you'll have to take care of that. |
|
bors r+ |
921: Get `SO_PEERCRED` working on all Linux targets r=asomers a=jonas-schievink These were disabled for ARM way back in 0db6ed1 and 09c00ed. Try to enable them for all arches and Android as well, since the removal wasn't really explained and I see no reason why this shouldn't work. Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
These were disabled for ARM way back in 0db6ed1 and 09c00ed. Try to enable them for all arches and Android as well, since the removal wasn't really explained and I see no reason why this shouldn't work.