Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IpMtu sockopt #1865

Merged
merged 1 commit into from Nov 25, 2022
Merged

Add IpMtu sockopt #1865

merged 1 commit into from Nov 25, 2022

Conversation

ShadowJonathan
Copy link
Contributor

@ShadowJonathan ShadowJonathan commented Nov 14, 2022 •
edited

Resolves #1864

@ShadowJonathan
Copy link
Contributor Author

I'm not sure why some linux tests are failing, they say ENOPROTOOPT, is networking not enabled on those architectures?

@asomers
Copy link
Member

asomers commented Nov 19, 2022

The architecture's where the tests are failing are the ones where we use qemu user-mode emulation in CI. Lots of stuff isn't enabled in qemu. You should add this to your test:

#[cfg_attr(qemu, ignore)]

asomers
asomers requested changes Nov 19, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget CHANGELOG.

src/sys/socket/sockopt.rs Outdated Show resolved Hide resolved
test/sys/test_sockopt.rs Show resolved Hide resolved
asomers
asomers reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please squash your commits?

asomers
asomers approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 25, 2022
@bors @ShadowJonathan
Merge #1865
a7a1426 
1865: Add IpMtu sockopt r=asomers a=ShadowJonathan

Resolves #1864

Co-authored-by: Jonathan de Jong <jonathandejong02@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 25, 2022

Build failed:

@asomers
Copy link
Member

asomers commented Nov 25, 2022

The clippy failure is fixed on master.

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 25, 2022

Build succeeded:

@bors bors bot merged commit 33a4d49 into nix-rust:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Linux IpMtu GetSockOpt
2 participants
@ShadowJonathan @asomers