Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. #1654

Merged
merged 1 commit into from Feb 6, 2022
Merged

Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. #1654

merged 1 commit into from Feb 6, 2022

Conversation

rtzoeller
Copy link
Collaborator

Expand accept4 support to more platforms.

@rtzoeller
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Feb 3, 2022
@bors @rtzoeller
Merge #1654
01983e7 
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

Timed out.

asomers
asomers approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors retry

bors bot added a commit that referenced this pull request Feb 5, 2022
@bors @rtzoeller
Merge #1654
9e8a54c 
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@asomers
Copy link
Member

asomers commented Feb 5, 2022

@rtzoeller I think bors is failing because there's no successful build for ""Linux armv7 uclibceabihf", which is in master's bors.toml but not this branch's. But this branch's .cirrus.yml is the one that is getting built. So perhaps rebasing would fix it?

@rtzoeller
Copy link
Collaborator Author

@rtzoeller I think bors is failing because there's no successful build for ""Linux armv7 uclibceabihf", which is in master's bors.toml but not this branch's. But this branch's .cirrus.yml is the one that is getting built. So perhaps rebasing would fix it?

I'll give that a shot in a few hours when I get home. Thanks!

@bors
Copy link
Contributor

bors bot commented Feb 5, 2022

Canceled.

@rtzoeller
Copy link
Collaborator Author

bors retry

bors bot added a commit that referenced this pull request Feb 5, 2022
@bors @rtzoeller
Merge #1654
57f8e62 
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@rtzoeller
Copy link
Collaborator Author

Hmm, @asomers it looks like bors is still having issues even after the rebase. All the jobs are stuck in "Running" and none are linked to any builds.

Did #1603 get something wrong?

@asomers
Copy link
Member

asomers commented Feb 5, 2022

I don't see anything wrong in that PR. It looks to me like it might be a bors problem. See https://app.bors.tech/batches/193727 . It doesn't think that any builds have finished yet.

@rtzoeller
Copy link
Collaborator Author

@asomers did bors' permissions/connection to access nix-rust/nix get reset somehow? I.e. at https://github.com/apps/bors

@asomers
Copy link
Member

asomers commented Feb 5, 2022

No, the configuration looks correct to me.

@rtzoeller
Copy link
Collaborator Author

@notriddle do you have any insight into what could be happening here? We're seeing bors show all jobs as running (e.g. in https://app.bors.tech/batches/193727), but none ever completing, leading to attempts timing out.

Thanks!

@asomers
Copy link
Member

asomers commented Feb 5, 2022

I opened a thread on the bors forum. If we can't get any help for a couple of days, I think we'll just have to start using the old-fashioned merge button. https://forum.bors.tech/t/bors-not-getting-build-notifications-for-nix-rust-nix/632

@bors
Copy link
Contributor

bors bot commented Feb 5, 2022

Timed out.

@notriddle
Copy link
Contributor

bors r=rtzoeller

@bors
Copy link
Contributor

bors bot commented Feb 5, 2022

🔒 Permission denied

Existing reviewers: click here to make notriddle a reviewer

@notriddle
Copy link
Contributor

bors r=rtzoeller

bors bot added a commit that referenced this pull request Feb 5, 2022
@bors @rtzoeller
Merge #1654
d49e30f 
1654: Add accept4 on DragonFly, Emscripten, Fuchsia, Illumos, and NetBSD. r=rtzoeller a=rtzoeller

Expand accept4 support to more platforms.

Co-authored-by: Ryan Zoeller <rtzoeller@rtzoeller.com>
@notriddle
Copy link
Contributor

I poked around through the API, but this really looks like a CI problem, and not a bors problem.

@rtzoeller
Copy link
Collaborator Author

Thanks for the investigation @notriddle!

And indeed, https://cirrus-ci.com/build/4744058793885696 shows the following error text:

Builds for public repositories initialized by applications are not supported.

I found cirruslabs/cirrus-ci-docs#972 which is reporting the same error, but with no resolution.

@bors
Copy link
Contributor

bors bot commented Feb 5, 2022

Timed out.

@asomers
Copy link
Member

asomers commented Feb 6, 2022

Fedor Korotkov said it's fixed. Let's find out.

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 6, 2022

Build succeeded:

@bors bors bot merged commit 0bd56d9 into nix-rust:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtzoeller @asomers @notriddle