Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define UMOUNT_NOFOLLOW, FUSE_SUPER_MAGIC #1634

Merged
merged 1 commit into from Jan 18, 2022

Conversation

rtzoeller
Copy link
Collaborator

Resolves #1631 and resolves #1633.

@rtzoeller
Copy link
Collaborator Author

Needs a changelog entry. Ideally this gets a libc release before being merged, but I wouldn't hold it for that alone.

@asomers
Copy link
Member

asomers commented Jan 14, 2022

LGTM, and the build failure is unrelated.

@rtzoeller
Copy link
Collaborator Author

@asomers how do you want to handle this deprecation, which is the source of the build failures? rust-lang/libc@ef1787a

@asomers
Copy link
Member

asomers commented Jan 14, 2022

On FreeBSD and NetBSD, it's documented as "reserved by system". I think we should just remove it from Nix.

@rtzoeller rtzoeller added this to the 0.24.0 milestone Jan 18, 2022
@rtzoeller rtzoeller marked this pull request as ready for review January 18, 2022 23:13
@rtzoeller
Copy link
Collaborator Author

bors r+

@bors bors bot merged commit c3731f1 into nix-rust:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define sys::statfs::FUSE_SUPER_MAGIC for linux Enhance mount::umount2 to support UMOUNT_NOFOLLOW flag
2 participants