Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose process_vm_readv, process_vm_writev for android #1557

Merged
merged 1 commit into from Feb 7, 2022

Conversation

rupansh
Copy link
Contributor

@rupansh rupansh commented Oct 12, 2021

@asomers
Copy link
Member

asomers commented Oct 16, 2021

Looks good. Could you please add a CHANGELOG entry and squash your commits?

@asomers asomers added this to the 0.24.0 milestone Oct 16, 2021
@rupansh rupansh force-pushed the master branch 2 times, most recently from 0aa9923 to 32b125f Compare October 17, 2021 22:28
@rupansh
Copy link
Contributor Author

rupansh commented Oct 17, 2021

done @asomers

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm going to avoid merging it until after 0.23.1.

@rtzoeller
Copy link
Collaborator

@rupansh can you rebase this? Thanks!

@rupansh rupansh force-pushed the master branch 2 times, most recently from e368882 to 1c66fd8 Compare February 3, 2022 09:56
@rupansh
Copy link
Contributor Author

rupansh commented Feb 3, 2022

done @rtzoeller

@rtzoeller
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Feb 3, 2022
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh

see rust-lang/libc#1878

Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
@bors

This comment was marked as outdated.

@rtzoeller
Copy link
Collaborator

bors retry

bors bot added a commit that referenced this pull request Feb 3, 2022
1557: expose process_vm_readv, process_vm_writev for android r=rtzoeller a=rupansh

see rust-lang/libc#1878

Co-authored-by: rupansh-arch <rupanshsekar@hotmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 4, 2022

Timed out.

@asomers
Copy link
Member

asomers commented Feb 5, 2022

@rupansh you probably need to rebase to satisfy bors.

@rupansh
Copy link
Contributor Author

rupansh commented Feb 5, 2022

@asomers I am over the latest commit in this repo (2143ffe). Can you be more specific?

@rtzoeller
Copy link
Collaborator

@rupansh apologies for the confusion and back and forth. There was an issue with our CI provider which is now resolved, but unfortunately in validating the fix a PR was submitted which made your PR conflict (I had originally planned to submit them in the opposite order).

Can you rebase again, hopefully for the final time? 😅

CHANGELOG: add process_vm_* entry
process_vm_*: fix documentation for android
expose process_vm_readv, process_vm_writev for android

Signed-off-by: rupansh-arch <rupanshsekar@hotmail.com>
@rupansh
Copy link
Contributor Author

rupansh commented Feb 7, 2022

done @rtzoeller

@rtzoeller
Copy link
Collaborator

bors r+

@bors bors bot merged commit 432fb90 into nix-rust:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants