Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more errno definitions for better backwards compat with 0.21.0 #1467

Merged
merged 1 commit into from Jul 15, 2021
Merged

Add more errno definitions for better backwards compat with 0.21.0 #1467

merged 1 commit into from Jul 15, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Jul 14, 2021

Fixes #1464

@asomers
Copy link
Member Author

asomers commented Jul 14, 2021

@sporksmith would the changes in this PR make the 0.21.0 -> 0.22.X upgrade easier for projects like yours?

@sporksmith
Copy link
Contributor

Yes, it looks like this would've turned some of the errors into warnings. In our particular case there were few enough that I just fixed all the errors and warnings at once, but I imagine this could be helpful for other projects.

@sporksmith
Copy link
Contributor

Fixes #1464

Did you mean #1466? Btw there was another kind of error that looks like wasn't included in the truncated error list in the compiler output I shared there; will add on to #1466 since I think it'd be orthogonal to this PR.

@asomers
Copy link
Member Author

asomers commented Jul 15, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2021

Build succeeded:

@bors bors bot merged commit 1a78595 into nix-rust:master Jul 15, 2021
@asomers asomers deleted the more_errnos branch July 24, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asomers @sporksmith