Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SO_RXQ_OVFL socket option (android/fuchsia/linux) #1455

Merged
merged 1 commit into from Jul 9, 2021
Merged

Support SO_RXQ_OVFL socket option (android/fuchsia/linux) #1455

merged 1 commit into from Jul 9, 2021
+125 −0

Conversation

junhochoi
Copy link
Contributor

This PR implements support of RXQ_OVFL flag and parsing ControlMessage
to get the packet drop counter of UDP socket.

@junhochoi junhochoi force-pushed the cmsg_rxq_ovfl branch 2 times, most recently from 922ef34 to 2335050 Compare June 19, 2021 03:06
asomers
asomers requested changes Jun 21, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a CHANGELOG entry. Also, what about Android and Fuchsia? libc defines this constant for them.

src/sys/socket/mod.rs Outdated Show resolved Hide resolved
src/sys/socket/mod.rs Outdated Show resolved Hide resolved
@junhochoi junhochoi force-pushed the cmsg_rxq_ovfl branch 3 times, most recently from d54f90c to cd8f7f7 Compare June 21, 2021 07:29
@junhochoi
Copy link
Contributor Author

Don't forget to add a CHANGELOG entry. Also, what about Android and Fuchsia? libc defines this constant for them.

I added CHANGELOG entry and addressed other comments. Thanks!

@junhochoi junhochoi changed the title Support SO_RXQ_OVFL socket option (Linux only) Support SO_RXQ_OVFL socket option (android/fuchsia/linux) Jun 21, 2021
@junhochoi junhochoi requested a review from asomers June 21, 2021 16:43
asomers
asomers requested changes Jul 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
asomers
asomers approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2021
@bors
Merge #1455
e540a35 
1455: Support SO_RXQ_OVFL socket option (android/fuchsia/linux) r=asomers a=junhochoi

This PR implements support of RXQ_OVFL flag and parsing ControlMessage
to get the packet drop counter of UDP socket.

Co-authored-by: Junho Choi <junho@cloudflare.com>
@bors
Copy link
Contributor

bors bot commented Jul 8, 2021

Build failed:

@asomers
Copy link
Member

asomers commented Jul 8, 2021

The tests are failing due to a just-landed PR on head.

@junhochoi
Copy link
Contributor Author

The tests are failing due to a just-landed PR on head.

rebased to master and pushed a fix.

@junhochoi
Copy link
Contributor Author

@asomers the build is green. should be good to go.

asomers
asomers approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 8, 2021
@bors
Merge #1455
4ba9530 
1455: Support SO_RXQ_OVFL socket option (android/fuchsia/linux) r=asomers a=junhochoi

This PR implements support of RXQ_OVFL flag and parsing ControlMessage
to get the packet drop counter of UDP socket.

Co-authored-by: Junho Choi <junho@cloudflare.com>
@bors
Copy link
Contributor

bors bot commented Jul 8, 2021

Timed out.

@asomers
Copy link
Member

asomers commented Jul 8, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Jul 8, 2021

Merge conflict.

@junhochoi
Support SO_RXQ_OVFL socket option (android/fuchsia/linux)
0b596a1 
This PR implements support of RXQ_OVFL flag and parsing ControlMessage
to get the packet drop counter of UDP socket.
@junhochoi
Copy link
Contributor Author

rebased to master again.

asomers
asomers approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 9, 2021

Build succeeded:

@bors bors bot merged commit 2957656 into nix-rust:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junhochoi @asomers