Add fuchsia support #1285

amanda-tait · 2020-08-05T17:36:51Z

This change adds support for the Fuchsia operating system to the nix
crate. Fuchsia developers have a use case for nix, particularly its safe
interfaces to the recvmsg(2) and sendmsg(2). Adding support requires:

incrementing the libc dependency to 0.2.74
conditionally not compiling nix functionality which depends on libc functionality
that does not exist for Fuchsia

amanda-tait · 2020-08-12T14:45:05Z

@asomers @kamalmarhubi @posborne

Friendly bump for code review. Thank you for taking a look.

posborne · 2020-08-13T19:38:00Z

@amanda-tait The change looks reasonable to me, is there any reasonable path for adding fuchsia support to CI. Without that, I fear it is pretty easy for other contributors to easily introduce regressions. I do not see CI support (or missed it) within libc either.

asomers · 2020-08-22T14:24:02Z

I see that rustup has a fuchsia target. If nothing else, we can add a CI target that cross-compiles to fuchsia, but doesn't run tests.

tamird · 2020-09-30T22:04:26Z

@posborne CI support is something we'd like to have, but Fuchsia does not yet provide tools for external CI.

We're OK with taking on the burden of fixing regressions.

asomers · 2020-10-03T01:57:56Z

The change looks good, but please add a CHANGELOG entry.

tamird · 2020-11-05T21:43:53Z

@asomers added a CHANGELOG entry and resolved the merge conflict.

tamird · 2020-11-05T22:05:41Z

@asomers I think cross compiling to Fuchsia would be great, do you have a suggestion on how to do that?

EDIT: added

tamird · 2020-11-12T15:20:21Z

@asomers I added a pair of commits to address upstream deprecations in libc, and this is now green and includes cross compilation to Fuchsia. Can you take a look?

asomers

Your PR now conflicts with #1329. But that PR requires your musl fix in order to build. Could you please split this PR into two? One for the musl fix, one for Fuchsia, and discard the af_alg_iv parts. Also, add Fuchsia to Tier 3 in the README.

asomers · 2020-11-15T16:42:06Z

.travis.yml

+        - curl --proto '=https' --tlsv1.2 -sSf --output rustup.sh https://sh.rustup.rs
+        - sh rustup.sh -y --profile=minimal --default-toolchain 1.36.0 --target x86_64-fuchsia
+        - . $HOME/.cargo/env
+        - cargo build --all-targets


You need to add --target x86_64-fuchsia to these two lines. (you probably copied this from the Redox section, which makes the same mistake; I'll fix that separately).

I don't think this is incorrect; the rustup invocation only installs the fuchsia target, so this does the right thing. The same is true for redox.

It is incorrect. I just checked in a fresh environment. The rustup invocation installs both the native toolchain and the one that you request with --target. So you need to do one of tho things:

Use --default-host instead of --target, or

Add --target x86_64-fuchsia to the cargo build line, as I suggested.

tamird · 2020-11-15T17:12:35Z

I can make the changes you requested, but I think the approach taken in #1329 is incorrect. As I mentioned in that PR, the deprecation is informational, and the approach taken there is far more brittle without any upside.

tamird · 2020-11-15T18:06:35Z

Added Fuchsia to Tier 3 in the README.

tamird · 2020-11-16T14:50:54Z

@asomers rebased now that #1332 is in.

tamird · 2020-11-16T21:06:59Z

CI is passing.

asomers · 2020-11-28T22:05:24Z

.travis.yml

+        - curl --proto '=https' --tlsv1.2 -sSf --output rustup.sh https://sh.rustup.rs
+        - sh rustup.sh -y --profile=minimal --default-toolchain 1.36.0 --target x86_64-fuchsia
+        - . $HOME/.cargo/env
+        - cargo build --all-targets


It is incorrect. I just checked in a fresh environment. The rustup invocation installs both the native toolchain and the one that you request with --target. So you need to do one of tho things:

Use --default-host instead of --target, or

Add --target x86_64-fuchsia to the cargo build line, as I suggested.

tamird · 2020-11-29T01:30:31Z

@asomers I can't seem to reply to your inline comment, but I've made the changes you requested and added Fuchsia to the list added in #1337.

tamird · 2020-12-15T11:26:50Z

Done.

tamird · 2020-12-15T17:20:55Z

Another flake.

---- test_fcntl::linux_android::test_vmsplice stdout ----
thread 'test_fcntl::linux_android::test_vmsplice' panicked at 'assertion failed: `(left == right)`
  left: `6`,
 right: `3`', test/test_fcntl.rs:198:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

asomers · 2020-12-16T03:04:44Z

Another flake.

---- test_fcntl::linux_android::test_vmsplice stdout ----
thread 'test_fcntl::linux_android::test_vmsplice' panicked at 'assertion failed: `(left == right)`
  left: `6`,
 right: `3`', test/test_fcntl.rs:198:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Sigh. This looks like a kernel bug. Or possibly a documentation bug. Is vmsplice allowed to write fewer bytes than were requested? The docs explicitly say that syscalls like write and sendfile may do that, but the man page for vmsplice is silent on the matter. In any case, it's certainly unrelated to this PR. For now, I'll try to rerun the check.

tamird · 2020-12-16T17:14:51Z

Thanks, looks like rerunning it worked. Is this good to land?

asomers · 2020-12-16T17:18:44Z

No, not yet. You still have that duped entry in the changelog.

tamird · 2020-12-16T17:45:18Z

Ah, sorry. It ended up in the second commit somehow. Done.

tamird · 2020-12-16T21:59:58Z

This is green again and I've made all the changes requested. Please have another look.

asomers

bors r+

1285: Add fuchsia support r=asomers a=amanda-tait This change adds support for the Fuchsia operating system to the nix crate. Fuchsia developers have a use case for nix, particularly its safe interfaces to the recvmsg(2) and sendmsg(2). Adding support requires: * incrementing the libc dependency to 0.2.74 * conditionally not compiling nix functionality which depends on libc functionality that does not exist for Fuchsia Co-authored-by: Tamir Duberstein <tamird@google.com> Co-authored-by: Amanda Tait <atait@google.com>

tamird · 2020-12-18T14:04:02Z

Is something wedged? Looks like this has been "waiting in queue" for 2 days (and I can't see the bors details page).

asomers · 2020-12-18T14:46:55Z

Cirrus is fine, but Bors is crashing.
bors-ng/bors-ng#1106
Hopefully fixed by #1365 .

tamird · 2020-12-18T15:46:38Z

Looks like that worked. Rebased.

tamird · 2020-12-18T19:24:27Z

@asomers looks like a network flake this time

error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-1.40.0.toml.sha256' to '/tmp/home/.rustup/tmp/4t0mcegb2twtxqn5_file'

Would you mind retrying it and submitting this once more?

Also, I'm not able to edit the PR description, but you might be able to -- could you edit it to reflect the second commit's message?

asomers · 2020-12-19T17:10:36Z

Also, I'm not able to edit the PR description, but you might be able to -- could you edit it to reflect the second commit's message?

What's wrong with the PR description?

tamird · 2020-12-19T19:15:26Z

The libc version is not modified.

This was missed in d363537.

Allow nix to compile on Fuchsia by conditionally avoiding libc functionality that does not exist for Fuchsia.

asomers

bors r+

bors · 2020-12-19T19:49:26Z

* I never removed 32-bit OSX and iOS targets that were removed from Cirrus in PR #1492 . * I never added Fuchsia (PR #1285) . * I never added illumos (PR #1394) . * never added Linux x32 (PR #1366) .

tamird force-pushed the fuchsia branch from 4942bce to 1ebd893 Compare November 5, 2020 21:43

tamird force-pushed the fuchsia branch from 1ebd893 to 82e1f66 Compare November 5, 2020 22:04

tamird force-pushed the fuchsia branch 7 times, most recently from 7303358 to cc46340 Compare November 11, 2020 19:54

tamird mentioned this pull request Nov 12, 2020

Avoid using libc::af_alg_iv to get rid of deprecation warnings #1329

Closed

jimblandy mentioned this pull request Nov 14, 2020

Make nix::sys::termios::Termios implement Sync and Copy. #1324

Open

asomers requested changes Nov 15, 2020

View reviewed changes

tamird force-pushed the fuchsia branch from cc46340 to 1d79e31 Compare November 15, 2020 18:06

tamird force-pushed the fuchsia branch from 1d79e31 to 2790f3a Compare November 16, 2020 14:50

asomers requested changes Nov 28, 2020

View reviewed changes

tamird force-pushed the fuchsia branch 2 times, most recently from 0f5a57b to bef48a2 Compare November 29, 2020 01:29

tamird force-pushed the fuchsia branch from f744d9a to f91bb6a Compare December 15, 2020 11:26

tamird force-pushed the fuchsia branch from f91bb6a to 9e1f7c4 Compare December 16, 2020 17:45

tamird force-pushed the fuchsia branch from 9e1f7c4 to e401edb Compare December 16, 2020 17:46

asomers approved these changes Dec 16, 2020

View reviewed changes

tamird force-pushed the fuchsia branch from e401edb to fcbf3ff Compare December 18, 2020 15:46

tamird and others added 2 commits December 19, 2020 14:17

Update cross-compilation Rust version to 1.40.0

16d62f6

This was missed in d363537.

Add fuchsia support

5846ae2

Allow nix to compile on Fuchsia by conditionally avoiding libc functionality that does not exist for Fuchsia.

tamird force-pushed the fuchsia branch from fcbf3ff to 5846ae2 Compare December 19, 2020 19:17

asomers approved these changes Dec 19, 2020

View reviewed changes

bors bot merged commit d07b7f8 into nix-rust:master Dec 19, 2020

tamird deleted the fuchsia branch December 19, 2020 22:56

This was referenced Mar 12, 2021

Bump nix from 0.19.1 to 0.20.0 nix-community/nix-user-chroot#34

Merged

Bump nix from 0.19.1 to 0.20.0 differs/Legends#12

Closed

build(deps): bump nix from 0.19.1 to 0.20.0 wangandi/materialize#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fuchsia support #1285

Add fuchsia support #1285

amanda-tait commented Aug 5, 2020

amanda-tait commented Aug 12, 2020

posborne commented Aug 13, 2020

asomers commented Aug 22, 2020

tamird commented Sep 30, 2020

asomers commented Oct 3, 2020

tamird commented Nov 5, 2020

tamird commented Nov 5, 2020 •

edited

tamird commented Nov 12, 2020

asomers left a comment

asomers Nov 15, 2020

tamird Nov 15, 2020

asomers Nov 28, 2020

tamird commented Nov 15, 2020

tamird commented Nov 15, 2020 •

edited

tamird commented Nov 16, 2020

tamird commented Nov 16, 2020

asomers Nov 28, 2020

tamird commented Nov 29, 2020

tamird commented Dec 15, 2020

tamird commented Dec 15, 2020

asomers commented Dec 16, 2020

tamird commented Dec 16, 2020

asomers commented Dec 16, 2020

tamird commented Dec 16, 2020

tamird commented Dec 16, 2020

asomers left a comment

tamird commented Dec 18, 2020

asomers commented Dec 18, 2020

tamird commented Dec 18, 2020

tamird commented Dec 18, 2020

asomers commented Dec 19, 2020

tamird commented Dec 19, 2020

asomers left a comment

bors bot commented Dec 19, 2020

Add fuchsia support #1285

Add fuchsia support #1285

Conversation

amanda-tait commented Aug 5, 2020

amanda-tait commented Aug 12, 2020

posborne commented Aug 13, 2020

asomers commented Aug 22, 2020

tamird commented Sep 30, 2020

asomers commented Oct 3, 2020

tamird commented Nov 5, 2020

tamird commented Nov 5, 2020 • edited

tamird commented Nov 12, 2020

asomers left a comment

Choose a reason for hiding this comment

asomers Nov 15, 2020

Choose a reason for hiding this comment

tamird Nov 15, 2020

Choose a reason for hiding this comment

asomers Nov 28, 2020

Choose a reason for hiding this comment

tamird commented Nov 15, 2020

tamird commented Nov 15, 2020 • edited

tamird commented Nov 16, 2020

tamird commented Nov 16, 2020

asomers Nov 28, 2020

Choose a reason for hiding this comment

tamird commented Nov 29, 2020

tamird commented Dec 15, 2020

tamird commented Dec 15, 2020

asomers commented Dec 16, 2020

tamird commented Dec 16, 2020

asomers commented Dec 16, 2020

tamird commented Dec 16, 2020

tamird commented Dec 16, 2020

asomers left a comment

Choose a reason for hiding this comment

tamird commented Dec 18, 2020

asomers commented Dec 18, 2020

tamird commented Dec 18, 2020

tamird commented Dec 18, 2020

asomers commented Dec 19, 2020

tamird commented Dec 19, 2020

asomers left a comment

Choose a reason for hiding this comment

bors bot commented Dec 19, 2020

tamird commented Nov 5, 2020 •

edited

tamird commented Nov 15, 2020 •

edited