From ba3f3e515a2c9ba7321e93c39c8b037c372d816b Mon Sep 17 00:00:00 2001 From: Nate Avers Date: Sun, 7 Jun 2020 13:57:29 -0400 Subject: [PATCH] Add fchown(2) wrapper. --- CHANGELOG.md | 2 ++ src/unistd.rs | 14 ++++++++++++++ test/test_unistd.rs | 18 ++++++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4df5615bf4..6b508e5cc9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] - ReleaseDate ### Added +- Added `fchown(2)` wrapper. + (#[1257](https://github.com/nix-rust/nix/pull/1257)) - Added support on linux systems for `MAP_HUGE_`_`SIZE`_ family of flags. (#[1211](https://github.com/nix-rust/nix/pull/1211)) - Added support for `F_OFD_*` `fcntl` commands on Linux and Android. diff --git a/src/unistd.rs b/src/unistd.rs index 8ff71e0532..c09e401949 100644 --- a/src/unistd.rs +++ b/src/unistd.rs @@ -651,6 +651,20 @@ pub fn chown(path: &P, owner: Option, group: Option, group: Option) -> Result<()> { + let (uid, gid) = chown_raw_ids(owner, group); + let res = unsafe { libc::fchown(fd, uid, gid) }; + Errno::result(res).map(drop) +} + /// Flags for `fchownat` function. #[derive(Clone, Copy, Debug)] pub enum FchownatFlags { diff --git a/test/test_unistd.rs b/test/test_unistd.rs index 0a41b65f5d..183d8337d4 100644 --- a/test/test_unistd.rs +++ b/test/test_unistd.rs @@ -17,6 +17,7 @@ use std::ffi::CString; use std::fs::DirBuilder; use std::fs::{self, File}; use std::io::Write; +use std::mem; use std::os::unix::prelude::*; use tempfile::{tempdir, tempfile}; use libc::{_exit, off_t}; @@ -409,6 +410,23 @@ fn test_chown() { chown(&path, uid, gid).unwrap_err(); } +#[test] +fn test_fchown() { + // Testing for anything other than our own UID/GID is hard. + let uid = Some(getuid()); + let gid = Some(getgid()); + + let path = tempfile().unwrap(); + let fd = path.as_raw_fd(); + + fchown(fd, uid, gid).unwrap(); + fchown(fd, uid, None).unwrap(); + fchown(fd, None, gid).unwrap(); + + mem::drop(path); + fchown(fd, uid, gid).unwrap_err(); +} + #[test] #[cfg(not(target_os = "redox"))] fn test_fchownat() {