Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Error::description #1175

Merged

Conversation

AnderEnder
Copy link
Contributor

Error::description has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:

  • Removes all implementations of description in all error types

Related PR: rust-lang/rust#66919

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this submission. Just one more thing: could you please add a CHANGELOG entry?

@AnderEnder AnderEnder force-pushed the remove-deprecated-error-description branch from 9dd3854 to edb2632 Compare December 29, 2019 20:29
@AnderEnder
Copy link
Contributor Author

@asomers, CHANGELOG was updated.

@AnderEnder
Copy link
Contributor Author

@asomers any news?

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks good!

bors r+

bors bot added a commit that referenced this pull request Jan 10, 2020
1175: Remove deprecated Error::description r=asomers a=AnderEnder

`Error::description` has been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.

This PR:
- Removes all implementations of `description` in all error types

Related PR: rust-lang/rust#66919

Co-authored-by: Radyk Andrii <ander.ender@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 10, 2020

Build succeeded

@bors bors bot merged commit edb2632 into nix-rust:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants