Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build with the next version of libc #2343

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asomers
Copy link
Member

@asomers asomers commented Mar 22, 2024

The next version of libc includes some backwards-incompatible changes.

Fixes #2342

@asomers asomers force-pushed the libc-0.2.154 branch 2 times, most recently from 5b0e24a to 3937ba4 Compare March 22, 2024 21:36
The next version of libc includes some backwards-incompatible changes.

Fixes nix-rust#2342
@asomers
Copy link
Member Author

asomers commented Mar 22, 2024

This PR sacrifices a little bit of type safety in order to build successfully with both old and new versions of libc. I'm not sure if we should merge it, just because I'm not sure if the libc folks are actually planning to release these changes as part of the 0.2 series.

@SteveLauC
Copy link
Member

This PR sacrifices a little bit of type safety in order to build successfully with both old and new versions of libc.

Given that the development of libc has been divided into 2 branches:

  • 0.2 (the libc-0.2 branch)
  • 1.0 (the main branch, previously it was 0.3)

I think we need to choose one to follow, from the tracking issue, there are still a lot of work to do to make libc 1.0 ready so I guess it won't happen in the near future, and it is recommended to file PRs against the libc-0.2 branch if one wants to make the patch available quickly, so we should probably go with 0.2?

However, most PRs are targeting the main branch, i.e., a lot of new APIs will be only available with libc 0.2.x, which makes it really hard to choose...

I'm not sure if we should merge it, just because I'm not sure if the libc folks are actually planning to release these changes as part of the 0.2 series.

These breaking changes are in the main branch, so I guess they won't be included in the future 0.2.x release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a package.rust-version entry that also needs to be updated if we are gonna bump our MSRV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build breakage with libc 0.2.154 from git
2 participants